View Issue Details

IDProjectCategoryView StatusLast Update
0003362OXID eShop (all versions)4.07. Source code, Testpublic2012-12-10 13:44
Reporteravenger 
PriorityhighSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.4 revision 39463 
Target VersionFixed in Version4.5.7 revision 41909 
Summary0003362: Bug in reading template image options
DescriptionIn "oxconfig.php" "function init()" template options are read with the following statement:

$this->_loadVarsFromDb( $sShopID, null, oxConfig::OXMODULE_THEME_PREFIX . $this->getConfigParam('sTheme') );

I.e., always the parameters of the basic theme are read, although there are options defined for the custom theme "sCustomTheme"....

Especially in an EE environment, where you have one basic theme and custom shop-themes this is not the correct way of handling this!

But also in a single shop environment you have to define the theme options in the basic scheme, not in your custom theme...

The routine should check the custom theme's options first, and only if those do not exist should use the basic theme's options
TagsNo tags attached.
ThemeBoth
BrowserAll
PHP Versionany
Database Versionany

Relationships

related to 0003035 resolvedmindaugas.rimgaila custom template files (tpl) not accessible 
related to 0002983 resolvedLinas Kukulskis Error message when selecting settings of custom theme 

Activities

dainius.bigelis

2012-01-23 11:17

reporter   ~0005619

@Developers: please check from the source code side if such check is needed.
It might be the similar problem as in 0003035 or 0002983

rimvydas_paskevicius

2012-01-24 09:44

reporter   ~0005634

Can you describe problem in more details? Currently shop loads all basic config variables and then loads custom theme config variables and they overrides basic config variables with same name.

rimvydas_paskevicius

2012-01-24 09:46

reporter   ~0005635

Reminder sent to: avenger

Please check note...

avenger

2012-01-24 09:54

reporter   ~0005636

Where ist it loadíng the custom theme config variables????

The only related code I found is this one, where ist loads the basic theme config.

================================
        try {
            $sShopID = $this->getShopId();

            // load now
            $this->_loadVarsFromDb( $sShopID );
            $this->_loadVarsFromDb( $sShopID, null, oxConfig::OXMODULE_THEME_PREFIX . $this->getConfigParam('sTheme') );


            //starting up the session
            $this->getSession()->start();

================================

If you have an Enterprise shop with one basic theme and several override templates for subshops, you can only define template parameters (e.g. image sizes) via the basic theme, although the config entries for rhe override themes have been created in the database.....

BTW:

The config entries for rhe override themes should be created automatically be the shop, inheriting them from the basic scheme...

The current process is very awkward, as you need a custom program to do that.

rimvydas_paskevicius

2012-01-24 15:50

reporter   ~0005645

Added custom theme (which has defined parent theme), config variables loading - custom theme config variables will override parent theme same config variables.