View Issue Details

IDProjectCategoryView StatusLast Update
0003225OXID eShop (all versions)1.01. Products (product, categories, manufacturer, promotions etc.)public2012-12-07 14:23
Reportertjungcl 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.2 revision 38481 
Target VersionFixed in Version4.5.3 revision 39087 
Summary0003225: reviews visible from inactive variants
Descriptionrelated to, but no duplicate of 0003223

when a user writes a review to a variant, which is later set to inactive,
the review is still shown in fronend.

For example: you have a jeans in 3 colors, where one color is very ugly and causes skin irritations. Many users give very bad reviews to that color and you ract by deactivating all variants of that color.
-> the reviews are still shown in frontend alothough you removed the article they refer to.

=> the function _getVariantsIds in oxarticle does not check the active flag.
(bug 0003223: it does not sort the ids).
It further not checks subshops, valid untils, out of stocks, etc.

TagsRatings, Reviews
ThemeBoth
BrowserAll
PHP Versionany
Database Versionany

Relationships

related to 0003223 resolvedvilma_liorensaityte oxarticle getVariantsIds returns ids unsorted 

Activities

svetlana

2011-09-15 12:17

reporter   ~0005215

Reminder sent to: tjungcl

Hi,

We tested this issue also with subshops, out of stocks but unfortunately we could not reproduce this it.
Maybe You did some changes in the code? or maybe do you have installed some Modules?

tjungcl

2011-09-15 13:11

reporter   ~0005216

I stumbled upon this issue in the source code and tested it in the 4.5 EE demoshop (because we dont have reviews enabled in our shop).

So, its definitly not caused by a module.

- visit a variant, write a review to that variant
- go to admin, open the variant, set the variant to inactive
- visit the variantparent in frontend and you still see the review of the now inactive variant

svetlana

2011-09-16 08:46

reporter   ~0005230

Reminder sent to: tjungcl


Thank you for you help, but I would like to check with you do we tested same as you do?
1. Open demo shop: http://demoshop.oxid-esales.com/enterprise-edition/ and login.
2. Search for product 3570(product with multidimensional products), and go to product detail.
3. Select size W31/L34 an Color Blue.
4. Go to Admin. Administer products->Product. Search for 3570. Select this product and go to Variants tab. Make this variant inactive.
5.Go to shop again and login. Search for product 3570 and go to product detail.
6. No review for parent product is shown. Select size W31/L34 an Color Blue, no review for this inactive variant too.

tjungcl

2011-09-16 08:58

reporter   ~0005231

I'll add the steps that are missing:

=> 0. Go to Admin, Settings => variants => show variant reviews at parent
1. Open demo shop: http://demoshop.oxid-esales.com/enterprise-edition/ [^] and login.
2. Search for product 3570(product with multidimensional products), and go to product detail.
3. Select size W31/L34 an Color Blue.
=> 3b. Write a comment for product 31/34 blue
4. Go to Admin. Administer products->Product. Search for 3570. Select this product and go to Variants tab. Make this variant inactive.
5.Go to shop again and login. Search for product 3570 and go to product detail.
=> You see the comment for inactive 31/34 blue now

svetlana

2011-09-19 12:14

reporter   ~0005237

This bug exist when option in Admin->Core Setting->System->Variants
"Show Variant Ratings for "Parent" Product" is set to ON.