View Issue Details

IDProjectCategoryView StatusLast Update
0003220OXID eShop (all versions)4.07. Source code, Testpublic2012-12-10 13:44
Status resolvedResolutionfixed 
Product VersionPast development 
Target VersionFixed in Version4.6.0_beta3 
Summary0003220: strange smarty code in zoom popup (rev 38514)
Descriptionthe loop for the zoom icons is as follows

            [{foreach from=$aZoomPics key=iPicNr item=_zoomPic}]
            [{assign var="_sZoomPic" value=$aZoomPics[$iPicNr].file}]

  •                     <a class="ox-zoompic ox-picnr-[{$iPicNr}] [{if $iPicNr == 1}]selected[{/if}]" href="[{$_sZoomPic}]">
                            <span class="marker"><img src="[{$oViewConf->getImageUrl('marker.png')}]" alt=""></span>

  •                 [{assign var="_sZoomPic" value=$aZoomPics[$iPicNr].file}]

    The part [{if $iPicNr == 1}]selected[{/if}] seems to be wrong, shouldnt it be $iPicNr == $iZoomPic ?

    And there are two assignments of _sZoomPic, which is only used once and could be replaced with $_zoomPic.file, resulting in

                [{foreach from=$aZoomPics key=iPicNr item=_zoomPic}]

  •                     <a class="ox-zoompic ox-picnr-[{$iPicNr}] [{if $iPicNr == $iZoomPic}]selected[{/if}]" href="[{$_zoomPic.file}]">
                            <span class="marker"><img src="[{$oViewConf->getImageUrl('marker.png')}]" alt=""></span>

  •             [{/foreach}]
    TagsNo tags attached.
    PHP Versionany
    Database Versionany



    2011-09-05 13:56

    reporter   ~0005175

    er... interesting. The form took the li-tag as html but nothing of the other html.
    But I think, its still readable what i mean :)

    Linas Kukulskis

    2012-03-21 18:02

    reporter   ~0006055

    fixed and cleaned up