View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003220 | OXID eShop (all versions) | 4.07. Source code, Test | public | 2011-09-05 13:54 | 2012-12-10 13:44 |
| Reporter | tjungcl | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | Past development | ||||
| Fixed in Version | 4.6.0_beta3 | ||||
| Summary | 0003220: strange smarty code in zoom popup (rev 38514) | ||||
| Description | the loop for the zoom icons is as follows [{foreach from=$aZoomPics key=iPicNr item=_zoomPic}] [{assign var="_sZoomPic" value=$aZoomPics[$iPicNr].file}] <a class="ox-zoompic ox-picnr-[{$iPicNr}] [{if $iPicNr == 1}]selected[{/if}]" href="[{$_sZoomPic}]"> <span class="marker"><img src="[{$oViewConf->getImageUrl('marker.png')}]" alt=""></span> [{$_zoomPic.id}] </a> [{assign var="_sZoomPic" value=$aZoomPics[$iPicNr].file}] [{/foreach}] The part [{if $iPicNr == 1}]selected[{/if}] seems to be wrong, shouldnt it be $iPicNr == $iZoomPic ? And there are two assignments of _sZoomPic, which is only used once and could be replaced with $_zoomPic.file, resulting in [{foreach from=$aZoomPics key=iPicNr item=_zoomPic}] <a class="ox-zoompic ox-picnr-[{$iPicNr}] [{if $iPicNr == $iZoomPic}]selected[{/if}]" href="[{$_zoomPic.file}]"> <span class="marker"><img src="[{$oViewConf->getImageUrl('marker.png')}]" alt=""></span> [{$_zoomPic.id}] </a> [{/foreach}] | ||||
| Tags | No tags attached. | ||||
| Theme | Azure | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
