View Issue Details

IDProjectCategoryView StatusLast Update
0003203OXID eShop (all versions)3.1. Design, GUI, UXpublic2011-09-13 14:56
Reporteraggrosoft 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.1 revision 38045 
Target VersionFixed in Version4.6.0_beta2 
Summary0003203: oxEqualizer does not take paddings into account
DescriptionFile out/azure/src/js/widgets/oxequalizer.js
Function equalHeight

The function does a good job as long as the group being sent in has no padding, otherwise the height calculation breaks. The problem is that the function assumes that equalizing the "height" property automatically makes the items same height on screen - this won't work if any paddings are active. The fix is quite easy:

if (target) {
       if (group.height() < target.height()){
              //Instead of just using target.height() we subtract the paddings before using innerHeight() - height()
              var h = target.height() - (group.innerHeight() - group.height());
              group.css("height", h);
        }
}
Steps To ReproduceUse oxequalizer on a group that has padding-top and / or padding-bottom,
Additional InformationI'm attaching the fixed file
TagsNo tags attached.
ThemeAzure
BrowserAll
PHP Versionany
Database Versionany

Relationships

has duplicate 0003202 closedbirute_meilutyte oxEqualizer does not take paddings into account 

Activities

aggrosoft

2011-08-30 15:34

reporter  

oxequalizer.js.zip (1,582 bytes)

birute_meilutyte

2011-08-31 09:24

reporter   ~0005150

@developers: please, investigate from source code side

Linas Kukulskis

2011-09-13 14:56

reporter   ~0005201

added suggesion