View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002938 | OXID eShop (all versions) | 1.02. Price calculations (discounts, coupons, additional costs etc.) | public | 2011-05-26 17:30 | 2012-12-07 15:07 |
| Reporter | cpjolly | Assigned To | |||
| Priority | urgent | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 4.5.0 revision 34568 | ||||
| Fixed in Version | 4.5.1 revision 38045 | ||||
| Summary | 0002938: isBelowMinOrderPrice does not add getNotDiscountProductsPrice to getDiscountedProductsBruttoPrice | ||||
| Description | In oxubase->isLowOrderPrice() calls oxbasket->isBelowMinOrderPrice(). This calls oxbasket->getDiscountedProductsBruttoPrice, but it does not call oxbasket->getNotDiscountProductsPrice, so it ignores the price of non discounted items. This is the same as fix 0001905 in oxbasket->getPriceForPayment(). oxbasket->isBelowMinOrderPrice() needs to add oxbasket->getNotDiscountProductsPrice() before calculating the total. Fix is as follows: public function isBelowMinOrderPrice() { $blIsBelowMinOrderPrice = false; $sConfValue = $this->getConfig()->getConfigParam( 'iMinOrderPrice' ); $dPrice = $this->getDiscountedProductsBruttoPrice(); if ( $oPriceList = $this->getNotDiscountProductsPrice() ) { $dPrice += $oPriceList->getBruttoSum(); } if ( is_numeric($sConfValue) && $this->getProductsCount() ) { $dMinOrderPrice = oxPrice::getPriceInActCurrency( ( int ) $sConfValue ); $blIsBelowMinOrderPrice = ($dMinOrderPrice > $dPrice); } return $blIsBelowMinOrderPrice; } | ||||
| Tags | Discount | ||||
| Theme | Both | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
