View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001689 | OXID eShop (all versions) | 2. ----- eShop backend (admin) ----- | public | 2010-03-09 11:05 | 2010-04-14 15:56 |
| Reporter | aggrosoft | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | no change required | ||
| Product Version | 4.2.0 revision 23610 | ||||
| Summary | 0001689: myorder::genPdf should be splitted | ||||
| Description | The supplied module for pdf generation is good as it is - but if you want to extend it to have another pdf file generated you have either override the genPdf method completely (like a hard copy) or create a new function in order_orderview. The following block of genPDF is problematic and should be moved to it's own method: // adding info data switch ( oxConfig::getParameter( 'pdftype' ) ) { case 'dnote': $this->exportDeliveryNote( $oPdf ); break; default: $this->exportStandart( $oPdf ); } If this would be part of it's own method you could just add in your own export commands without copying the whole genPDF method. | ||||
| Additional Information | This is a small tweak that makes extending the pdf output much easier to maintain for everyone. | ||||
| Tags | No tags attached. | ||||
| Theme | |||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
|
|
As I take a closer look at this class there are a lot of methods that should be splitted - extending an already existing export function is also very uncomfortable. |
|
|
Reminder sent to: aggrosoft Hi, Thank you for your notes. We added as a task to refactor this place to our todo's list. So this will be done in future releases. Best regards, |
|
|
Closed, as this request was included in ToDo list for future releases. |
