View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001201 | OXID eShop (all versions) | 1.03. Basket, checkout process | public | 2009-08-14 11:11 | 2012-12-07 15:13 |
| Reporter | csimon | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Fixed in Version | 4.1.6 revision 22740 | ||||
| Summary | 0001201: Call time pass by reference | ||||
| Description | Hi, method executePayment needs reference of oOrder Object. this is deprecated and should be removed. Causes warnings with efi paypal. line 80: public function executePayment( $dAmount, & $oOrder ) | ||||
| Tags | Payment | ||||
| Theme | |||||
| Browser | All | ||||
| PHP Version | 5.2.6 | ||||
| Database Version | 5.0.33 | ||||
|
|
@Developers: please check from the source code side. |
|
|
as long as the reference is done in function declaration its ok. Only referencing in function call is deprecated, see http://us2.php.net/manual/en/language.references.pass.php In the mentioned code sample, its correct. |
|
|
Had a look at paypal module files. in efi_paypal_oxpaymentgateway.php line 198 a reference is done in a function call: return parent::ExecutePayment($dAmount, & $oOrder); This should cause the warning. |
|
|
yes, posted wrong line. this was exactly what was causing the error |
