View Issue Details

IDProjectCategoryView StatusLast Update
0000893OXID eShop (all versions)4.09. SEO, SEO URLpublic2012-12-10 13:35
Reporterarvydas_vapsva 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.1.2 revision 18998 
Target VersionFixed in Version4.1.3 revision 19918 
Summary0000893: Unable to delete SEO meta keywords/description
DescriptionWhen you enter meta description or keywords in admin, you can not delete them any more
TagsNo tags attached.
Theme
BrowserAll
PHP Version5.2.6
MySQL Version5.0.33

Activities

arvydas_vapsva

2009-05-14 09:24

reporter   ~0000918

problem is in oxSeoEncoder::_saveToDb() method, and keyword/description value check:

  $sKeywords = $sKeywords ? $oDb->quote( $oStr->htmlentities( $this->encodeString( strip_tags( $sKeywords ), false ) ) ) : false;
  $sDescription = $sDescription ? $oDb->quote( $oStr->htmlentities( strip_tags( $sDescription ) ) ) : false;

should be replaced by:

  if ( $sKeywords !== false ) {
    $sKeywords = $oDb->quote( $oStr->htmlentities( $this->encodeString( strip_tags( $sKeywords ), false ) ) );
  }

  if ( $sDescription !== false ) {
    $sDescription = $oDb->quote( $oStr->htmlentities( strip_tags( $sDescription ) ) );
  }

But replacing is not a fix in general, as other standart calls are affected by this problem - default value should be false, instead previous ''..

So fix comes with next version