| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0006657 | OXID eShop (all versions) | 1.02. Price calculations (discounts, coupons, additional costs etc.) | public | 2017-06-28 11:35 | 2024-04-03 11:33 |
| Reporter | vanilla thunder | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | confirmed | Resolution | open | ||
| Product Version | 4.10.2 / 5.3.2 | ||||
| Summary | 0006657: Product and category coupon's value calculated from article's basket price instead of actual basketitem price | ||||
| Description | category and product coupons take product's original price for calculating discount value instead of getting the actual basketitem price, which could be alredy reduced. You get the biggest side effect when combining discounts and coupons at same time, e.g. you offer 33% discount for a product "buy 3, pay 2" and also 10% for particular products or categories. When bots discount and coupon are valid for the product in your basket, both discount and coupon values are calculated with the original undiscounted price. | ||||
| Steps To Reproduce | 1) product X costs 300€ 2) crate 100 € discount for product X 3) crate 10% coupon test666 4) add X to basket 5) you see: product X - 200€ ([del]300€[/del]) 6) enter coupon code test666 7) coupon value is calculated based on 200€ price -> 20€ 8) assign product xor its category to the coupon series 9) recalculate basket 10) coupon discoutn value is calculated based on product's original price 300€ -> 30€ | ||||
| Additional Information | compare functions: oxVoucher::_getGenericDiscoutValue oxVoucher::_getCategoryDiscoutValue oxVoucher::_getProductDiscoutValue _getGenericDiscoutValue uses passed $dPrice from oxBasketitem for discount values calcultion _getCategoryDiscoutValue and _getProductDiscoutValue get array of basket items from function _getSessionBasketItems (inside _getBasketItems), but it contains prices from $oArticle->getBasketPrice(...), which are undiscounted. Using $oBasketItem->getUnitPrice()->getPrice() instead, would give the current price of the basket item here is my fix approach: $aItems[$iCount] = array( 'oxid' => $oArticle->getId(), //'price' => $oArticle->getBasketPrice($oBasketItem->getAmount(), $oBasketItem->getSelList(), $oBasket)->getPrice(), 'price' => $oBasketItem->getUnitPrice()->getPrice(), //'discount' => $oDiscount->getAbsValue($oArticle->getBasketPrice($oBasketItem->getAmount(), $oBasketItem->getSelList(), $oBasket)->getPrice()), 'discount' => $oDiscount->getAbsValue($oBasketItem->getUnitPrice()->getPrice()), 'amount' => $oBasketItem->getAmount(), ); | ||||
| Tags | No tags attached. | ||||
| Theme | Not defined | ||||
| Browser | Not defined | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
- Anonymous
