View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0006286||OXID eShop (all versions)||4.09. SEO, SEO URL||public||2015-12-11 15:59||2015-12-14 10:02|
|Product Version||4.9.5 / 5.2.5|
|Target Version||Fixed in Version|
|Summary||0006286: _prepareMetaDescription: Parameter sMeta never used|
|Description||I am writing a custom SEO module. The method "_prepareMetaDescription" in Class "aList" overwrites the base method defined in "oxUBase". |
In aList it has the sMeta Parameter as first parameter but does nothing with it. So it is impossible to set a custom meta description and use the _prepareMetaDescription function for it. In oxUBase it's correct.
Also in oxUBase function "getMetaDescription" the function _prepareMetaDescription is actually called with an argument $sDescription – but this will never work, as described above.
I changed the function in my fork of OXID eShop on Github, so you better understand the problem. The code is tested in EE 5.2.5 and allows custom meta description as well as the usual behaviour:
|Additional Information||GitHub Commit: https://github.com/OXID-eSales/oxideshop_ce/commit/a5a80313132288646d1a2815f1b3bb53fd1f2d8c|
|Tags||No tags attached.|
|Database Version||Not defined|
The reporter is right.
But since the method aList::_prepareMetaDescription is never used, I assume that it can be removed anyway. The class aList uses each time the method _prepareMetaDescription from the class oxUBase, because the callings are made with they keyword parent (parent::_prepareMetaDescription).