View Issue Details

Jump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0005908OXID eShop (all versions)2.8. Servicepublic2014-10-05 14:552023-12-06 15:49
Reportergerldental Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Product Version4.8.7 / 5.1.7 
Summary0005908: Price alert list: problem with brutto/netto price mode in shop
Descriptionin pricealarm_list.tpl in line 112:

... [{ $listitem->getFPrice() }]

This function returns always brutto-price and seems to be deprecated ( why just not using here oxprice object? )

in oxpricealarm.php:

00129 public function getPrice()
00130 {
00131 if ( $this->_dPrice == null ) {
00132 $this->_dPrice = false;
00133 if ( $oArticle = $this->getArticle() ) {
00134 $myUtils = oxRegistry::getUtils();
00135 $oThisCurr = $this->getPriceAlarmCurrency();
00136
00137 // #889C - Netto prices in Admin
00138 // (we have to call $oArticle->getPrice() to get price with VAT)
00139 $dArtPrice = $oArticle->getPrice()->getBruttoPrice() * $oThisCurr->rate;
00140 $dArtPrice = $myUtils->fRound( $dArtPrice );
00141
00142 $this->_dPrice = $dArtPrice;
00143 }
00144 }
00145 return $this->_dPrice;
00146 }

in the comment: "#889C - Netto prices in Admin"

but after 1 line: $dArtPrice = $oArticle->getPrice()->getBruttoPrice() * $oThisCurr->rate;

(?!) where not better "$oArticle->getPrice()->getPrice()" in this place?
TagsNo tags attached.
ThemeAzure
BrowserAll
PHP VersionNot defined
Database VersionNot defined

Activities

There are no notes attached to this issue.