View Issue Details

IDProjectCategoryView StatusLast Update
0004918OXID eShop (all versions)3.2. HTML, CSS, JavaScriptpublic2013-02-14 15:56
ReporterBugganeer 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.7.3 / 5.0.3 revision 54408 
Target VersionFixed in Version4.8.0_5.1.0_beta1 
Summary0004918: Dots in article oxID's lead to nonfunctional compare article javascript in oxcomparelinks.js
DescriptionSince i always import directly over SQL and i like my oxID's more meaningful than a hash, i stumbled over this one.

In Line 34 and 35 of oxcomparelinks.js the id is just passed on to jQuery selector.

$('a.compare.add[data-aid='+id+']').css('display','none');
$('a.compare.remove[data-aid='+id+']').css('display','block');

After you click on the add to compare button, all other articles are showing the remove from compare button as well.

This issue is likely not limited to dots.
Steps To ReproduceAdd/Import Articles with oxid's which contain a dot.
Click the add to compare list button in the front end. (Azure)
Additional Information            if (list) {
                $.each(list, function(id) {
+ id = id.replace(/\./,"\\.");
                    $('a.compare.add[data-aid='+id+']').css('display','none');
                    $('a.compare.remove[data-aid='+id+']').css('display','block');

It did work for me, but as mentioned, other chars could break this script as well.
TagsNo tags attached.
ThemeAzure
BrowserAll
PHP Versionany
MySQL Versionany

Activities

There are no notes attached to this issue.