View Issue Details

IDProjectCategoryView StatusLast Update
0004629OXID eShop (all versions)4.07. Source code, Testpublic2012-12-10 13:44
Reporterrr 
PriorityhighSeveritytrivialReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.6.5 revision 49955 
Target VersionFixed in Version4.6.6 revision 54646 
Summary0004629: shop_config::_loadConfVars() is public even though it begins with an underscore
DescriptionIn admin/shop_config.php (line 188) the _loadConfVars() method is declared as public, even though the method name begins with an underscore and therefore indicates a protected method by convention.

Should the method indeed be public, or is this a typo?

The same goes for OXID eShop 4.7.0 RC1 (application/controllers/admin/shop_config.php line 189).
TagsNo tags attached.
ThemeBoth
BrowserAll
PHP Versionany
MySQL Versionany

Activities

There are no notes attached to this issue.