View Issue Details

Jump to Notes
IDProjectCategoryView StatusDate SubmittedLast Update
0003136OXID eShop (all versions)1.02. Price calculations (discounts, coupons, additional costs etc.)public2011-08-11 15:142012-12-07 15:07
ReporterReignman Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version4.5.0 revision 34568 
Fixed in Version4.5.2 revision 38481 
Summary0003136: delete() of oxvoucherseries has no return
DescriptionFunction is missing a return value.
For me its bad because ERP doesnt return blResult on successful delete.

    /**
     * Override delete function so we can delete user group and article or category relations first.
     *
     * @param string $sOxId object ID (default null)
     *
     * @return null
     */
    public function delete( $sOxId = null )
    {
        if ( !$sOxId ) {
            $sOxId = $this->getId();
        }

            if ( !$this->canDelete( $sOxId ) ) {
                return false;
            }

        $this->unsetDiscountRelations();
        $this->unsetUserGroups();
        $this->deleteVoucherList();
        parent::delete( $sOxId );
    }
Steps To Reproduceobvious
Additional Informationfixed by writing a module with return.
TagsDiscount
ThemeBoth
BrowserAll
PHP Versionany
Database Versionany

Activities

svetlana

2011-08-11 15:54

reporter   ~0004998

@developers: please investigate from source code side.