View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003057 | OXID eShop (all versions) | 1.06. Search, Tags | public | 2011-07-14 14:40 | 2012-12-07 14:39 |
| Reporter | tjungcl | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | no change required | ||
| Product Version | 4.5.0 revision 34568 | ||||
| Fixed in Version | 4.5.1 revision 38045 | ||||
| Summary | 0003057: search default is uppercase forced in tpl | ||||
| Description | The value for the default search value is ident SEARCH_TITLE from lang-php. It is forced to uppercase in the template (with |upper). This should better be done via CSS or in the lang-php directly because as its now the tpl has to be changed if a shopowner wants the text not uppercased. | ||||
| Tags | Search | ||||
| Theme | Azure | ||||
| Browser | All | ||||
| PHP Version | any | ||||
| Database Version | any | ||||
|
|
in team we decided that |upper is the best way to do that, because only with css its impossible to do (entered users text must be as typed not converted). to do it in language file also not very good. |
|
|
Ok. The css way doesnt work, your right. So I removed the |upper from my lokal copy of search.tpl and that solved the bug https://bugs.oxid-esales.com/view.php?id=3056 The sDefaultValue for the function oxInnerLabel has to be |upper too, or the upper has to be removed alltogether and the SEARCH_TITLE in lang.php just be made uppercase. You wrote thats not very good. Why? If a user wants it uppercase, he can make in uppercase, if not then not. Whats wrong about it? |
|
|
0003056 already fixed. use uppers in language files is not proper, because all text styling we do with css or with smarty modifiers and only in last way is to uppercase in lang file. |
