View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005503 | OXID ERP Interface | OXID ERP Interface - sub | public | 2013-11-06 10:04 | 2024-01-25 08:35 |
| Reporter | michael_keiluweit | Assigned To | |||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | no change required | ||
| Product Version | 2.11.1_54476 | ||||
| Summary | 0005503: Confusing names of two methods | ||||
| Description | The method OXERPSetArticleCategory can set one article to one or more categories. The method OXERPSetObject2Category can set one or more articles to one category. So the names should like OXERPSetArticle2Categories and OXERPSetArticles2Category | ||||
| Tags | No tags attached. | ||||
|
|
just an idea: Because we use singular and plural namings of other objets (example: OXERPGetOrderArticleFile -> OXERPGetOrderArticleFiles) we need a second method like OXERPSETArticles2Category to make the differents more clearier. But I am not 100% sure because we use this only for the getters, but it would also make sense to use this at setters. If we follow the line to set everytime one object, than the method OXERPSetObject2Category has one feature which no other setter method has and it breaks the rules. |
|
|
Technically it states that OXERPSetObject2Category is not only for article -> category relationships. |
