View Issue Details

IDProjectCategoryView StatusLast Update
0006950Wave themeThemepublic2019-02-08 10:27
Reportermario_lorenz Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status acknowledgedResolutionopen 
Summary0006950: Grunt Concat JS: Some libs are concat, even though they are extra loaded
DescriptionThese resources are also bundled into the javascript.js, although they are still loaded in the templates additionally.

'<%= project.dev %>build/vendor/jquery-flexslider2/js/jquery.flexslider.js',
'<%= project.dev %>build/js/pages/compare.js',
'<%= project.dev %>build/js/pages/details.js',
'<%= project.dev %>build/js/pages/review.js',
'<%= project.dev %>build/js/pages/start.js'
Additional InformationSolution: Either the resources are not bundled, or the extra loadings disappear in the templates.
TagsNo tags attached.

Activities

QA

2019-02-07 16:53

administrator   ~0012778

Last edited: 2019-02-07 16:53

Where do you see a usage of javascript.js in wave theme?

-MF

mario_lorenz

2019-02-07 17:37

developer   ~0012779

@QA: to bundle the files is your first step. After this you uglify the javascript.js to scripts.min.js.

Your mistake is, that you load in ...
\tpl\page\shop\start.tpl -> js/pages/start.min.js
\tpl\page\details\inc\productmain.tpl -> js/pages/details.min.js
... the files seperatly. Only in ...
\tpl\page\review\review.tpl
\tpl\page\compare\compare.tpl
... did you´ve comment out the js includes.