View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0005859 | OXID eShop (all versions) | 2.1. Master Settings | public | 2014-08-27 15:35 | 2023-12-06 14:35 |
| Reporter | hendrikfreytag | Assigned To | |||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | no change required | ||
| Product Version | 4.9.0_5.2.0_beta1 | ||||
| Summary | 0005859: Missing documentation: Mall URL must contain http | ||||
| Description | In the mall settings of a subshop you can specify a URL. This has to contain http at the beginning, but there is no documentation for that. Maybe it would be even better not only to write documentation for that but to check this before saving. | ||||
| Steps To Reproduce | Go to enterprise shop, create a new shop and set it's url to something with missing protocol. | ||||
| Tags | Documentation | ||||
| Theme | Azure | ||||
| Browser | All | ||||
| PHP Version | Not defined | ||||
| Database Version | Not defined | ||||
|
|
Problem with that is, that the method isCurrentUrl in oxConfig or oxUtilsServer assumes an URL without http as true. And this function is used to get a shop id. So a shop without an http in url will be the default which can break everything. |
|
|
This is related to https://github.com/OXID-eSales/oxideshop_ce/pull/190 |
|
|
I am resolving this because the documentation now clearly states that the protocol is required. But rest assured that I have this on my list of features to be implemented. The arguments in https://github.com/OXID-eSales/oxideshop_ce/pull/191 are absolutely valid and were also noted in several other communications by several partners and encountered in several projects already. Handling protocol, domain and path in a clean way is the cue to a lot of possible features and also a good opportunity to improve the code. |
