View Issue Details

IDProjectCategoryView StatusLast Update
0004890OXID eShop (all versions)4.07. Source code, Testpublic2023-11-17 14:06
ReporterLinas Kukulskis Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version4.7.3 / 5.0.3 revision 54408 
Fixed in Version4.6.0 revision 44406 
Summary0004890: remove method oxArticle::isNotBuyable()
Descriptionremove "oxArticle::isNotBuyable()" and leave only "oxArticle::isBuyable()". This will lead to code refactoring. (see https://bugs.oxid-esales.com/view.php?id=3092, https://bugs.oxid-esales.com/view.php?id=1655)
TagsNo tags attached.
ThemeNot defined
BrowserAll
PHP VersionNot defined
Database VersionNot defined

Activities

SvenBrunk

2023-11-17 14:06

administrator   ~0015794

It is not necessary to remove the method. isBuyable is already (from version 4.6 at least) only a negation of "isNotBuyable".
The only thing that differs is that something might also be not buyable if the parent is not buyable
https://github.com/OXID-eSales/oxideshop_ce/blob/3cd732605ea823d8276e48156440b62584c57101/source/Application/Model/Article.php#L773